Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Window::request_redraw on Android #1953

Merged
merged 3 commits into from Jun 5, 2021
Merged

Implement Window::request_redraw on Android #1953

merged 3 commits into from Jun 5, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 28, 2021

This implements Window::request_redraw on Android based on the feedback given here: #1822 (comment)

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

Fixes #1723

CHANGELOG.md Outdated Show resolved Hide resolved
@maroider maroider added DS - android C - waiting on maintainer A maintainer must review this code labels May 28, 2021
@maroider maroider requested a review from msiglreith May 28, 2021 21:30
Copy link
Member

@msiglreith msiglreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please update the request_redraw documentation. It still contains a section stating it's not supported on Android. Up to my understanding this doesn't handle subsequent `request_redraw' calls after main event cleared so this should be added as platform specific.

@msiglreith msiglreith merged commit 67cca71 into rust-windowing:master Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - waiting on maintainer A maintainer must review this code DS - android
Development

Successfully merging this pull request may close these issues.

Android redraw requests aren't implemented
2 participants