Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Window visibility regression #1994

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

msiglreith
Copy link
Member

Fixes #1980

The visible attribute was not correctly applied in case the decorations were disabled. Reordering to ensure that a WM_NCCALCSIZE (I think that's the desired event) is triggered due to size update.

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch

CHANGELOG entry omitted as the regression is not in any release.

@msiglreith msiglreith requested a review from maroider August 11, 2021 21:58
Ensure that the style change is correctly applied, triggering the necessary events.
Copy link
Member

@maroider maroider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear to me why we don't/can't make the window invisible immediately upon creation instead of deferring it like this, but this change seems to fix the bug for me.

src/platform_impl/windows/window.rs Outdated Show resolved Hide resolved
Co-authored-by: Markus Røyset <maroider@protonmail.com>
@msiglreith msiglreith merged commit b87757c into rust-windowing:master Aug 12, 2021
@msiglreith msiglreith deleted the win-visible branch August 12, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - waiting on maintainer A maintainer must review this code DS - windows
Development

Successfully merging this pull request may close these issues.

Borderless transparent windows don't appear (#1933 regression)
2 participants