Fix transparency on X11 #2006
Fix transparency on X11 #2006
Conversation
|
does this mean that we can finally have transparent windows in winit with vulkan/wgpu? |
|
No, this only affects X11(so a specific subset of Linux) it will don't do anything for any other platform furthermore I just tested the hello-triangle example with transparent background using a local clone of wgpu repo with the winit dependency pointing to my fork, and it worked smoothly contrary to before where you only saw a black background where it should be transparent. As I said this only affects X11, that issue seems present on multiple platforms. |
maroider
added
DS - x11
C - waiting on maintainer
| } else { | ||
| // There is not a visual that matches the criteria of being `TrueColor` and 32 bits depth, | ||
| // and panic or error is not appropiate so just ignore it and continue | ||
| (ffi::CopyFromParent, ffi::CopyFromParent as *mut ffi::Visual) | ||
| } |
There was a problem hiding this comment.
I think it's a good idea to log a debug message here like
debug!("Could not set transparency, because XMatchVisualInfo returned zero for the required parameters");There was a problem hiding this comment.
Addressed, thank you
|
Thank you for this pr. i have been waiting for wgpu transparency for months. i thought the issue was with wgpu all this time. <3 |
|
It is okay I was building a library to use winit with tiny-skia after realize that wgpu don't support transparency, then it doesn't worked as I expected am I |
This PR fixes the broke transparency feature on X11.
Note that for this feature matrix said that this already worked, but it was code as TODO and only would work if someone provide a custom visual, which is not documented. This PR fixes that, allowing winit to find an appropriate visual for transparency.
This also fix this issue in wgpu for X11 allowing to create transparent background(I just tried that, I didn't do extensive testing).
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to users