-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Bump ndk/ndk-glue version #2047
Conversation
@@ -125,6 +126,6 @@ To ensure compatibility with older MacOS systems, winit links to | |||
CGDisplayCreateUUIDFromDisplayID through the CoreGraphics framework. | |||
However, under certain setups this function is only available to be linked | |||
through the newer ColorSync framework. So, winit provides the | |||
`WINIT_LINK_COLORSYNC` environment variable which can be set to `1` or `true` | |||
`WINIT_LINK_COLORSYNC` environment variable which can be set to `1` or `true` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't strictly speaking related to the ndk in any way, but trailing whitespace also annoys me...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right I missed that part. I'm experimenting with it a bit and not sure yet - adding features (e.g #[cfg_attr(target_os = "android", ndk_glue::main(backtrace = "on", ndk_glue = "winit::platform::android::ndk_glue"))]
fn main() {
...
} Overall I would probably keep it out for now. Maybe somehow has a suggestion how properly export it. The above attempts doesn't look so user friendly. |
cargo fmt
has been run on this branchcargo doc
builds successfullyCHANGELOG.md
if knowledge of this change could be valuable to usersTested with a small sample application that it still runs with the updated ndk version.
This is breaking as users need to update their version of
ndk-glue
as well as it internally has a static global variable which should be unique across crates!#1995