Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump versions of ndk to 0.6, ndk-sys to 0.3, ndk-glue to 0.6 #2163

Merged
merged 5 commits into from
Jan 31, 2022
Merged

Bump versions of ndk to 0.6, ndk-sys to 0.3, ndk-glue to 0.6 #2163

merged 5 commits into from
Jan 31, 2022

Conversation

enfipy
Copy link
Contributor

@enfipy enfipy commented Jan 27, 2022

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@maroider maroider added DS - android C - waiting on maintainer A maintainer must review this code labels Jan 28, 2022
msiglreith
msiglreith reviewed Jan 28, 2022
View reviewed changes
Copy link
Member

@msiglreith msiglreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please update the version section in the readme.

@enfipy
Copy link
Contributor Author

enfipy commented Jan 28, 2022

Thanks, please update the version section in the readme.

Sure, any plans on releasing a new patch version of winit? Or place it as part of winit v0.26?

@madsmtm
Copy link
Member

madsmtm commented Jan 28, 2022

These are breaking changes (because ndk is a public dependency), and should be noted as such in the changelog (and we'll have to release it as part of winit v0.27.0)

madsmtm
madsmtm reviewed Jan 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@enfipy
Copy link
Contributor Author

enfipy commented Jan 28, 2022

@madsmtm Updated as you requested.

madsmtm
madsmtm approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@msiglreith msiglreith merged commit f93f2c1 into rust-windowing:master Jan 31, 2022
@enfipy enfipy deleted the patch-2 branch February 1, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msiglreith msiglreith msiglreith approved these changes

@madsmtm madsmtm madsmtm approved these changes

Assignees
No one assigned
Labels
C - waiting on maintainer A maintainer must review this code DS - android
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enfipy @madsmtm @msiglreith @maroider