Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XIM support for sending spot to IME #223

Merged
merged 5 commits into from
Jul 18, 2017
Merged

XIM support for sending spot to IME #223

merged 5 commits into from
Jul 18, 2017

Conversation

Determinant
Copy link
Contributor

This exposes an API that enables the app to adjust the IME box according to the cursor position.

@Determinant Determinant mentioned this pull request Jul 13, 2017
Closed
Ralith
Ralith approved these changes Jul 16, 2017
View reviewed changes
Copy link
Contributor

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review the guts of the XIM wrangling, but otherwise this looks okay to me. A cross-platform solution would be nice but may not be feasible, and shouldn't block something like this regardless.

@jwilm
Copy link
Contributor

jwilm commented Jul 18, 2017

LGTM as well. Several other applications with XIM support take a similar approach.

@tomaka
Copy link
Contributor

tomaka commented Jul 18, 2017

I have absolutely no idea what a "XIM spot" is.

@Determinant
Copy link
Contributor Author

Determinant commented Jul 18, 2017 •
edited
Loading

@tomaka https://www.x.org/releases/X11R7.6/doc/libX11/specs/libX11/libX11.html#id2792209
TLDR: "spot" means the location hint sent to the selected input method in X11. It is used by the input method to reposition its editing window. Screenshot to illustrate: alacritty/alacritty#44 (comment).

@tomaka
Copy link
Contributor

tomaka commented Jul 18, 2017

Well, I don't have anything against this change.

@tomaka tomaka merged commit 2066909 into rust-windowing:master Jul 18, 2017
tmfink pushed a commit to tmfink/winit that referenced this pull request Jan 5, 2022
@pcwalton
Implement the drawImage() method on canvas.
cd37791 
Closes rust-windowing#223.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Determinant @jwilm @tomaka @Ralith