Update raw-window-handle to v0.5.0 #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I take it we're aiming to land this in |
Yeah, I think so. |
kchibisov
force-pushed
the
udpate-raw-window-handle
branch
from
d9b3719
to
ca63edb
Compare
maroider
reviewed
Jul 16, 2022
Yeah, I'll land |
|
I've updated implementation and now use traits for it. Waiting on ndk to update, so android will start built. |
You might get away with bumping the commit hash to rust-mobile/ndk@814be08? |
Yeah, but I don't mind waiting for you to release ndk, given that it'll be this week according to you (can't wait™). |
maroider
reviewed
Jul 20, 2022
This updates raw-window-handle to v0.5.0. The change is breaking and removes the old `HasRawWindowHandle` trait implementation, but that's intentional given that internal structs got renamed.
kchibisov
force-pushed
the
udpate-raw-window-handle
branch
from
366aa5a
to
84bca1f
Compare
maroider
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates raw-window-handle to v0.5.0. The change is breaking
and removes the old
HasRawWindowHandletrait implementation,but that's intentional given that internal structs got renamed.