Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 0.28.0 #2600

Closed
wants to merge 22 commits into from
Closed

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Dec 21, 2022

The changelog is getting larger, and it was indirectly requested in #2157 (comment) that we do a new release soon; so let's start the discussion of what that would entail.

See also the milestone.

Tagging major library consumers, to ask what their timelines on releases are (so that we can somewhat coordinate on them, like, if you're planning a release on a specific date, we could try to release 0.28 shortly before that) (do tell me if I should tag someone else too in the future):

EDIT: Moved to #2634

msiglreith and others added 22 commits September 11, 2022 19:59
This fix CI building due to implicit rust version
bump in examples.
- Pass WM_SYSKEYDOWN to DefWindowProc
- Avoid intercepting WM_SYSCHAR to allow ALT+Space to work: removes ReceivedCharacter events for alt+keypress
- Intercept WM_MENUCHAR to disable bell sound
* Fix iOS 32-bit

* Fix a few invalid message sends on iOS
This reverts commit 4895a29.

GitHub Actions' runner-images readded this environment variable on my
request [1] as it wasn't strictly related to the deprecated and removed
`ndk-bundle` NDK release.  Back out of the workaround to keep CI scripts
tidy.

[1]: actions/runner-images#5879 (comment)
Winit uses raw-window-handle of version 0.4.3,
but only 0.4.0 was specified.
This script is confusing and provides no value especially
with release branches and patch fixes.
This should help downstream to automatically clear it.
Currently needed for downstream users relaying on `ReceivedCharacter` for implementing
keybindings.
During reload we were picking old styles, but the styles could
change during reload leading to errors during IME building.

Fixes rust-windowing#2510.
Even when the protocol explicitly tells to send proper UTF-8
boundaries for cursor, some IMEs don't do that, so sanity check
them before sending downstream.
@madsmtm madsmtm added C - needs discussion Direction must be ironed out S - maintenance Repaying technical debt labels Dec 21, 2022
@madsmtm madsmtm added this to the Version 0.28 milestone Dec 21, 2022
@alice-i-cecile
Copy link

Bevy's next release is scheduled for approximately the start of February.

@alice-i-cecile
Copy link

alice-i-cecile commented Dec 22, 2022

If Fyrox uses winit we should tag them too :)

@kchibisov
Copy link
Member

The way you've created branch is not correct, and you should create the branch. Consult the https://github.com/rust-windowing/winit/blob/master/CONTRIBUTING.md#release-process if you want to do a release, right now it seems like you've opened it against the master branch and has a weird history of commits. It should be just one comment at this point.

Regardless other issues, I'd probably like to solve more issues from the milestone, they are there for a reason. I don't think that there's a strong need for winit.

At least I'd suggest to go through the patches we have from @amrbashir since they are small and some of them like #2585 is a breaking change, since it could change the focused semantics.

As well as including RedoxOs support (cc @jackpot51).

I've updated the milestones and suggest to iterate through out the small patches at least.

I'd also like to bring Wayland fractional scaling patch, but it's hard for me to verify it given that most stuff wrt it is in works, so I'd like to wait for it for a bit, since it's a major change that is long awaited.

--

I would suggest to open issues instead of PRs if you want to discuss, but that's unrelated. Though, we can use it as an issue, given that you've opened PR against wrong branch and you'll have to recreate it anyway :p.

@madsmtm
Copy link
Member Author

madsmtm commented Dec 27, 2022

I agree with everything you said, and yeah, let's continue with using this PR for discussion and then create a new one when we're ready.

I think I'd like to aim for sometime around mid January, so I guess I'll try to make a push for the things in the milestone in the new year.

@nobbele
Copy link

nobbele commented Jan 14, 2023

I think I'd like to aim for sometime around mid January, so I guess I'll try to make a push for the things in the milestone in the new year.

Is there an update to this ETA? The new release of ggez should be ready now.

@kchibisov
Copy link
Member

Not sure about ETA, but I'd start preparing release soon...

@kchibisov
Copy link
Member

Closing due to branch being opened against master.

@kchibisov kchibisov closed this Jan 17, 2023
@madsmtm madsmtm deleted the new-release branch January 22, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - needs discussion Direction must be ironed out S - maintenance Repaying technical debt
Development

Successfully merging this pull request may close these issues.