Implement Sync for EventLoopProxy (except on Web)
#2749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
requested review from
msiglreith,
madsmtm,
kchibisov and
jackpot51
as code owners
daxpedda
changed the title
Sync for EventLoopProxy (except for Web)Sync for EventLoopProxy (except on Web)
daxpedda
force-pushed
the
event-loop-proxy-sync
branch
from
90631a5
to
a23ccf6
Compare
|
CI is currently broken. Partly fixed by #2750. |
daxpedda
force-pushed
the
event-loop-proxy-sync
branch
from
a23ccf6
to
aaf1a44
Compare
|
Closed. We decided it's kinda pointless because users can just wrap it around a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
SyncforEventLoopProxyfor all platforms except Web, which is done in a separate PR (#2740). I tested this only on Linux and Windows, but I think it's pretty safe to say this should just work.