On macOS, fix tabGroup misuse #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
commented
Oct 17, 2023
kchibisov
commented
Oct 17, 2023
The property is marked as `Weak`, however we used strong `Id`. Links: alacritty/alacritty#7249
kchibisov
force-pushed
the
fix-tabbed-group-get
branch
from
092dc2e to
29d3313
Compare
|
Handling is done the same as other APIs already do that, so it's either will fork just fine or they are all broken anyway. |
|
Thanks for doing this, your solution is exactly as I'd done it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property is marked as
Weak, however we used strongId.Links: alacritty/alacritty#7249