On Windows, confine cursor to center of window when grabbed and hidden #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
msiglreith
reviewed
Mar 7, 2024
msiglreith
approved these changes
Mar 16, 2024
kchibisov
requested changes
Mar 16, 2024
kchibisov
approved these changes
Mar 18, 2024
This fixes issues where a hidden and grabbed cursor could leave the
window and become visible on top of the windows taskbar (and potentially
leave the window altogether if the taskbar is clicked) under at least
two occasions:
- When a window is overlapping the taskbar.
- When a window is maximized and Automatically hide the taskbar has
been enabled.
This approach of confining the cursor to the center of the window is
used in SDL.
kchibisov
force-pushed
the
windows-confine-center
branch
from
2f313c1 to
eabd472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues where a hidden and grabbed cursor could leave the window and become visible on top of the windows taskbar (and potentially leave the window altogether if the taskbar is clicked) under at least two occasions:
Automatically hide the taskbarhas been enabled.This approach of confining the cursor to the center of the window is used in SDL.
CHANGELOG.mdif knowledge of this change could be valuable to users