x11: Set window title prior to mapping window #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
approved these changes
Dec 13, 2017
Fixes rust-windowing#282 Some tiling window managers (i3, dwm, etc.) determine how a window should behave based on its name. If the name is set after mapping, then window managers will check the name before we set it, followed by them detecting it as a change when the name is actually set. That results in the window briefly behaving in an unexpected way, followed by a rapid switch to the expected behavior. In accordance to section 4.1.2 of ICCCM, the name, decorations, size hints, and window deletion redirection have all been moved up to be set before mapping.
francesca64
force-pushed
the
x11-earlier-title
branch
from
d414288 to
49d700a
Compare
tmfink
pushed a commit
to tmfink/winit
that referenced
this pull request
Jan 5, 2022
`usvg` should never have nested `<svg>` nodes, so remove code that (doesn't) handle that case. Closes rust-windowing#349.
madsmtm
pushed a commit
to madsmtm/winit
that referenced
this pull request
Jun 11, 2022
…dowing#362) * refactor(tray): split gtk and ayatana appindicator features * fix ci * install dev package * fix: use v3 * chore: short feature flag name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #282
Some tiling window managers (i3, dwm, etc.) determine how a window should behave based on
its name. If the name is set after mapping, then window managers will check the name before
we set it, followed by them detecting it as a change when the name is actually set. That
results in the window briefly behaving in an unexpected way, followed by a rapid switch to
the expected behavior.
In accordance to section 4.1.2 of ICCCM, the name, decorations, size hints, and window
deletion redirection have all been moved up to be set before mapping.