Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: use the word "Web" correctly and consistently #3785

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

daxpedda
Copy link
Member

Removing any public mentions of web-sys, because its currently the only backend we support anyway, so this is a historical leftover when we were still supporting stdweb.

About the casing of "Web", apparently OED (Oxford English Dictionary) says its capital unless used in a compound word, e.g. "I am surfing the Web." vs "I am a web user.". Unfortunately I can't link to the OED because its behind a paywall. I didn't want to spend time actually figuring out what exactly are compound words or aren't, so I just opted to use capital casing everywhere.

Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WebSys should go away from the docs as well?

Also, it's not clear why docsrs was added.

@daxpedda
Copy link
Member Author

The WebSys should go away from the docs as well?

CI was failing because of that, fixed it now.

Also, it's not clear why docsrs was added.

Because when cfg(docsrs) is enabled it can be linked, that's the whole purpose of this cfg, to avoid linking to it when its not present.

@daxpedda daxpedda requested a review from kchibisov July 10, 2024 13:51
@kchibisov
Copy link
Member

But it'll fail when building for docsrs because Web is not present? Like I don't see what was wrong with the old cfg check without docsrs.

@daxpedda
Copy link
Member Author

But it'll fail when building for docsrs because Web is not present?

But Web is present for docsrs?
See #3076 if you don't remember.
Or if you have a way to reproduce a error/warning please share it.

Like I don't see what was wrong with the old cfg check without docsrs.

This is just an improvement.

Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, forgot that we check docsrs, should be good.

@daxpedda daxpedda merged commit d5fd868 into rust-windowing:master Jul 10, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants