iOS: Refactor event handling to share code with macOS #3865
Conversation
madsmtm
force-pushed
the
madsmtm/uikit-cleanup-event-handling
branch
from
6ae7dc4 to
9d42d00
Compare
Instead of storing the event handler within the AppState, and extracting it our every time we need it, we now use the same event handling implementation as for macOS that ensures we don't re-entrantly call the event handler, and that we un-register the handler again after we're done using it (`UIApplicationMain` won't return, but may still unwind, so this is very important for panic safety).
madsmtm
force-pushed
the
madsmtm/uikit-cleanup-event-handling
branch
from
9d42d00 to
6e9d0dc
Compare
| static GLOBAL: StaticMainThreadBound<OnceCell<EventHandler>> = | ||
| StaticMainThreadBound(OnceCell::new()); |
There was a problem hiding this comment.
Remembering our talk about not storing anything in static memory.
No clue what the story here is exactly.
There was a problem hiding this comment.
I think I would still like to achieve that at some point, but it's going to be quite difficult with the event handler (especially so on AppKit, where we have to submit events from inside -[NSApplication sendEvent:], without the ability to store anything there, since I plan to swizzle (replace) the method to avoid requiring WinitApplication being registered as the main application).
The EventHandler is effectively moved from AppState, which is already stored in a static, so this PR doesn't really change the status quo (we just have two smaller statics now, instead of one big one).
Instead of storing the event handler within the AppState, and extracting it our every time we need it, we now use the same event handling implementation as for macOS that ensures we don't re-entrantly call the event handler, and that we un-register the handler again after we're done using it (
UIApplicationMainwon't return, but may still unwind, so this is very important for panic safety).This is the first step of me trying to untangle the inscrutable mess that is the current event handling on iOS.