Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] WindowBuilderExt additions for the titlebar #389

Closed
wants to merge 3 commits into from
Closed

[macOS] WindowBuilderExt additions for the titlebar #389

wants to merge 3 commits into from

Conversation

robertgzr
Copy link
Contributor

Extends the WindowBuilder on macOS to allow more fine-grained modifications to the way the titlebar is displayed.

@robertgzr
Copy link
Contributor Author

This addresses some points in this issue #323

@robertgzr robertgzr mentioned this pull request Jan 24, 2018
Closed
@sodiumjoe sodiumjoe mentioned this pull request Feb 4, 2018
Closed
@sodiumjoe sodiumjoe mentioned this pull request Feb 19, 2018
Merged
@paulrouget
Copy link
Contributor

Do we really need that? Could this be achieved by using WindowExt::get_nswindow() in Alacritty.

Winit could provide sane defaults, and if one wants to do more, use the native handle and do all the tweaks?

@robertgzr
Copy link
Contributor Author

@paulrouget

Yes, I guess downstream projects could just use that to achieve the same look and more...
But why not offer these simple switches in winit? Together with #408 this would offer a lot of control over the look of the window, without the user having to delve into the specifics of macOS UI development :)

And regarding the sane defaults, don't we already have them? Depending on with_decorations you either get a default looking window or one without any titlebar/borders.

@paulrouget
Copy link
Contributor

I don't have a strong opinion about this. Happy with both approaches.

@sodiumjoe sodiumjoe mentioned this pull request Mar 18, 2018
Merged
@robertgzr robertgzr mentioned this pull request Mar 20, 2018
Closed
@robertgzr
Copy link
Contributor Author

Closing as it was included in #423

@robertgzr robertgzr closed this Mar 23, 2018
@PaperPrototype PaperPrototype mentioned this pull request Mar 1, 2021
Closed
tmfink pushed a commit to tmfink/winit that referenced this pull request Jan 5, 2022
@bors-servo
Auto merge of rust-windowing#389 - pcwalton:gradient-wrap, r=pcwalton
7fceca9 
Implement gradient wrap/spread modes in SVG.

Closes rust-windowing#386.
madsmtm pushed a commit to madsmtm/winit that referenced this pull request Jun 11, 2022
@amrbashir @FabianLars
fix(linux): make menubar background transparent (rust-windowing#389)
a0d9408 
* fix(linux): make menubar background transparent

* fix build

* use css provider

* remove shadow

* add changefile

* only when window is transparent

* update change file

* fix typo in changefile

Co-authored-by: Fabian-Lars <fabianlars@fabianlars.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaka tomaka tomaka approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertgzr @paulrouget @tomaka