Missing X11 FocusIn event #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
requested changes
Sep 3, 2024
Comment on lines
879
to
894
| let focused = self.with_window(window, |window| { | ||
| let mut shared_state_lock = window.shared_state_lock(); | ||
| if !shared_state_lock.has_focus { | ||
| shared_state_lock.has_focus = true; | ||
| true | ||
| } else { | ||
| false | ||
| } | ||
| }); | ||
| if focused == Some(true) { | ||
| let event = Event::WindowEvent { window_id, event: WindowEvent::Focused(true) }; | ||
| callback(&self.target, event); | ||
| } |
There was a problem hiding this comment.
Should only send focus event when we actually will be sending anything related to the keyboard input.
There was a problem hiding this comment.
Even if this particular keyboard event does not end in notifying the user of anything, my argument was that if I'm getting this X11 event here it is because this window has the focus. And if shared_state_lock.has_focus is false, then I should already have received it, so I'm sending it now to compensate for the missing one.
rodrigorc
force-pushed
the
MissingX11FocusIn
branch
from
9ae0200
to
d4eff84
Compare
It should be done before mapping the window, or we could lose the firsst XInput2 events, such as the first FocusIn. Fixes rust-windowing#2841.
rodrigorc
force-pushed
the
MissingX11FocusIn
branch
from
b9f7ed6
to
8257144
Compare
|
Hi! This seems to have stalled a bit. I think adding two unrelated "fixes" to the focus was a mistake. I'm rewriting the PR to just include the fix for #2841, that should be easier to merge. |
kchibisov
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2841.
Also it adds and extra commit that synthesizes a FocusIn event if ever the window receives a keyboard event while unfocused, that should not happen, but it does happen sometimes.
Feel free to comment on those two commits separately, if you prefer that.