Fix x11 window size calculations #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix for returning accurate window position lead to a regression computing inner size in pixels. This commit resolves that by getting inner size from the window ID winit caches and still resolving position by climbing the window hierarchy. Resolves rust-windowing#398
sodiumjoe
pushed a commit
to sodiumjoe/winit
that referenced
this pull request
Mar 19, 2018
The fix for returning accurate window position lead to a regression computing inner size in pixels. This commit resolves that by getting inner size from the window ID winit caches and still resolving position by climbing the window hierarchy. Resolves rust-windowing#398
tmfink
pushed a commit
to tmfink/winit
that referenced
this pull request
Jan 5, 2022
… r=pcwalton Make `canvas_text` example render on expose Before this change, the `canvas_text` example would become blank after navigating to another workspace or being put beneath another window. This change will listen for the SDL window exposed event, and will render then instead of only at the beginning.
madsmtm
pushed a commit
to madsmtm/winit
that referenced
this pull request
Jun 11, 2022
Co-authored-by: lucasfernog <lucasfernog@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for returning accurate window position lead to a regression
computing inner size in pixels. This commit resolves that by getting
inner size from the window ID winit caches and still resolving position
by climbing the window hierarchy.
Resolves #398