macOS: improve IME state management #4087
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog
module if knowledge of this change could be valuable to usersFixes #3925
The basic idea of this change is: when IME is allowed, we always forward key events to the IME first, and use the result from the IME. Simpler keyboards, like the US keyboard, is also correctly supported by this.
Summary of changes:
Ime::Enabled
whenset_ime_allowed(true)
. Do not manage it elsewhere. This is a huge simplification, and it should be harmless to current conforming applications.What is improved:
q
(toggles katakana) should work properly. Previously, SKK is not usable at all.(Korean IMEs work mostly fine but #3095 is not fixed by this PR: the first key will generate a call to
insertText:
instead ofsetMarkedText:
, which seems unrelated to the problems this PR tries to fix.)