Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: add builder method to make a tool window #4123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

windows: add builder method to make a tool window #4123

wants to merge 2 commits into from

Conversation

lunixbochs
Copy link
Contributor

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

Updated version of #2719

@lunixbochs lunixbochs requested a review from notgull as a code owner February 11, 2025 05:37
notgull
notgull approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@notgull notgull requested a review from kchibisov February 16, 2025 18:15
@kchibisov
Copy link
Member

Could you rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

@kchibisov kchibisov kchibisov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lunixbochs @kchibisov @notgull