Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows creates Alt event instead of Menu event. (to match other platforms) #551

Merged
merged 3 commits into from
Jun 13, 2018

Conversation

rukai
Copy link
Contributor

@rukai rukai commented Jun 5, 2018

Fixes #549

LMenu + RMenu is from the original batch of events copied from some windows list by tomaka 24baf4d
While LAlt + RAlt were added later. f86af01

Because LAlt + RAlt is used on every other platform, and its a better description, I propose we delete LMenu + RMenu and point the windows key events LMenu + RMenu to LAlt + RAlt instead.

State of other platforms:

@rukai rukai changed the title Windows creates Alt event instead of Menu event. (to match X11) Windows creates Alt event instead of Menu event. (to match other platforms) Jun 5, 2018
…nerates VirtualKeyCode::LAlt + VirtualKeyCode::RAlt instead.
@francesca64
Copy link
Member

Thanks! This looks like a thorough investigation, and I'm definitely in favor of this change.

mac os looks looks like it isnt implemented?

Ha, that would explain why I get virtual_keycode: None when pressing the alt key on macOS. I'm surprised I never noticed. I'll tack a quick fix for that onto this, if you don't mind.

@francesca64
Copy link
Member

I just remembered that I'm not supposed to merge a breaking change before the 0.15.1 release, so this will have to wait until after I fix a few more bugs.

@francesca64
Copy link
Member

...RWin and LWin are also swapped on macOS. Don't tell anyone this, but I have a lot of trouble distinguishing left from right.

@francesca64 francesca64 merged commit f083dae into rust-windowing:master Jun 13, 2018
pengowen123 added a commit to pengowen123/piston that referenced this pull request Jul 9, 2018
According to rust-windowing/winit#551, LAlt + RAlt are used
instead on every platform
pengowen123 added a commit to pengowen123/piston that referenced this pull request Jul 9, 2018
According to rust-windowing/winit#551, LAlt + RAlt are used
instead on every platform
yvt added a commit to yvt/ngspades that referenced this pull request Apr 25, 2020
- Added the XML documentation for `Presentation.VirtualKeyCode`.
- Updated the XML documentation for `Presentation.KeyModifierFlags`.
- Removed `LMenu` and `RMenu` from `Presentation.VirtualKeyCode` since
  `winit` will generate `[LR]Alt` instead of them in further versions:
  <rust-windowing/winit#551>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants