625 macos modifiers #629
Merged
625 macos modifiers #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2018
|
just tested with this branch of alacritty and it appears to work great |
francesca64
reviewed
Aug 15, 2018
src/platform/macos/events_loop.rs
Outdated
| appkit::NSKeyUp => { | ||
| if let Some(key_window) = maybe_key_window() { | ||
| if event_mods(ns_event).logo { | ||
| msg_send![*key_window.window, sendEvent:ns_event]; |
There was a problem hiding this comment.
Don't forget the let _: (). #428
|
Thanks! This looks great. |
This was referenced Aug 16, 2018
|
@francesca64 any chance of shipping another patch so we can get this downstream into alacritty/alacritty#1403 😅 |
|
Yeah, feel free to make a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to usersfixes #625
fixes #623