Commits on Jun 25, 2019

1. Remove XFlush call in event loop …

   Internally, `XFlush` calls `_XSend` to write data. It then calls
   `XEventsQueued(display, QueuedAfterReading)`, which reads data from the
   X server connection. This prevents the event loop source callback from
   being run, as there is no longer data waiting on the socket.
   
   Ideally, we would want to call `_XSend` directly to ensure that no
   output is buffered by Xlib. However, this function is not exported as
   part of Xlib's public API.
   
   Testing with the `XFlush` call removed does not appear to adversely
   affect the performance of an application. If any bugs should eventually
   arise from this change, perhaps another function may be used in place of
   `XFlush`, such as `XPending`, which writes buffered output but does not
   so aggressively read from the X server connection.
   
   Closes rust-windowing#865

   

   murarth committed Jun 25, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 1cf5801
   • Browse repository at this point

   Copy the full SHA

   1cf5801 View commit details

   Browse the repository at this point in the history