-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build for windows with VS2019 #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
It looks like something is broken with the actions workflow definitions which is why they are not showing up in status checks. You'll need to fix that before we can get this merged.
.github/workflows/build-and-test.yml
Outdated
continue-on-error: ${{ matrix.experimental }} | ||
strategy: | ||
matrix: | ||
os: [ubuntu-latest, windows-2019] | ||
toolchain: [stable, beta] | ||
experimental: [false] | ||
include: | ||
- toolchain: nightly | ||
experimental: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that you've added a new entry to the matrix the include
part is wrong. I think we can get away with dropping the experimental
bit and doing this instead:
continue-on-error: ${{ matrix.experimental }} | |
strategy: | |
matrix: | |
os: [ubuntu-latest, windows-2019] | |
toolchain: [stable, beta] | |
experimental: [false] | |
include: | |
- toolchain: nightly | |
experimental: true | |
continue-on-error: ${{ matrix.toolchain == 'nightly' }} | |
strategy: | |
matrix: | |
os: [ubuntu-latest, windows-2019] | |
toolchain: [stable, beta, nightly] |
I'm not 100% sure that this works though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much
No description provided.