Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build for windows with VS2019 #63

Closed
wants to merge 4 commits into from

Conversation

flier
Copy link
Contributor

@flier flier commented Jan 2, 2024

No description provided.

@flier flier changed the title build for windows build for windows with VS2019 Jan 2, 2024
Copy link
Member

@Phantomical Phantomical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

It looks like something is broken with the actions workflow definitions which is why they are not showing up in status checks. You'll need to fix that before we can get this merged.

Comment on lines 15 to 23
continue-on-error: ${{ matrix.experimental }}
strategy:
matrix:
os: [ubuntu-latest, windows-2019]
toolchain: [stable, beta]
experimental: [false]
include:
- toolchain: nightly
experimental: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you've added a new entry to the matrix the include part is wrong. I think we can get away with dropping the experimental bit and doing this instead:

Suggested change
continue-on-error: ${{ matrix.experimental }}
strategy:
matrix:
os: [ubuntu-latest, windows-2019]
toolchain: [stable, beta]
experimental: [false]
include:
- toolchain: nightly
experimental: true
continue-on-error: ${{ matrix.toolchain == 'nightly' }}
strategy:
matrix:
os: [ubuntu-latest, windows-2019]
toolchain: [stable, beta, nightly]

I'm not 100% sure that this works though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much

@flier flier closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants