Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ctru-rs for the latest libctru release #91

Closed
3 tasks done
Meziu opened this issue Feb 11, 2023 · 2 comments
Closed
3 tasks done

Update ctru-rs for the latest libctru release #91

Meziu opened this issue Feb 11, 2023 · 2 comments
Assignees
@AzureMarker @ian-h-chamberlain @Techie-Pi

Comments

@Meziu
Copy link
Member

Meziu commented Feb 11, 2023 •
edited
Loading

libctru just released the latest 2.1.2 version: https://github.com/devkitPro/libctru/releases/tag/v2.1.2.

There have been numerous changes, but the one that influences us the most is the native addition of clock_gettime. We should update our repos accordingly.

Furthermore, @ian-h-chamberlain's thread changes have been released! Does this help with the thread_localPRs?

PRs to be merged:
@ian-h-chamberlain
Copy link
Member

ian-h-chamberlain commented Feb 11, 2023 •
edited
Loading

Yes, we should be able to re-enable #[thread_local] finally on Rust main now! I also wonder if citro3d-rs will need any updates to account for the changes made in ctru-sys... If I have some time this weekend I'll take a look at both of those and will link here once I have PRs.

It looks like some of the APIs changed to use size_t instead of u32 now too? Nice to have less as casts

@Meziu
Copy link
Member Author

Meziu commented Feb 12, 2023

@rust3ds/active Great stuff. I’ve merged the changes, I remind everybody to do (dkp-)pacman -Syu cargo clean and cargo update before using the toolchain. 😃

@Meziu Meziu closed this as completed Feb 12, 2023
@ian-h-chamberlain ian-h-chamberlain mentioned this issue Feb 12, 2023
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Feb 15, 2023
@Dylan-DPC
Rollup merge of rust-lang#107968 - ian-h-chamberlain:feature/3ds-enab…
587e3df 
…le-thread-local, r=Nilstrieb

Enable `#[thread_local]` on armv6k-nintendo-3ds

Since [libctru 2.1.2](https://github.com/devkitPro/libctru/releases/tag/v2.1.2)  was released we should now be able to use real `#[thread_local]` without corruption issues on the 3DS target.

CC `@Meziu` `@AzureMarker` `@Techie-Pi`
rust3ds/ctru-rs#91 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AzureMarker AzureMarker

@ian-h-chamberlain ian-h-chamberlain

@Techie-Pi Techie-Pi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AzureMarker @ian-h-chamberlain @Techie-Pi @Meziu