Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: add tor support #59

Merged
merged 1 commit into from
Aug 7, 2024
Merged

node: add tor support #59

merged 1 commit into from
Aug 7, 2024

Conversation

rustaceanrob
Copy link
Owner

No description provided.

oleonardolima
oleonardolima reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! I'll take a look on pinning the dependencies.

Maybe we should also have a separate example just for Tor usage 🤔

src/lib.rs
Comment on lines +22 to +24
pub use arti_client::TorClient;
#[cfg(feature = "tor")]
pub use arti_client::TorClientConfig;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can fit this under a single use, can't you? 🤔

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah just got lazy

@rustaceanrob
Copy link
Owner Author

I added Tor to the memory.rs example. Could maybe use a rename

@oleonardolima
Copy link
Contributor

I added Tor to the memory.rs example. Could maybe use a rename

Yep, I mean was it being used for other purposes, or it's fine to "steal" it for Tor purposes ?

@rustaceanrob
Copy link
Owner Author

Yeah I think it can demonstrate both. The in-memory peer database should be rare or never used.

@rustaceanrob rustaceanrob marked this pull request as ready for review August 7, 2024 15:20
@rustaceanrob rustaceanrob merged commit 678b56f into master Aug 7, 2024
12 checks passed
@rustaceanrob rustaceanrob deleted the tor branch August 10, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleonardolima oleonardolima oleonardolima left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustaceanrob @oleonardolima