feat: update contribution workflow based on guideline generated as comment #251
Conversation
✅ Deploy Preview for scrc-coding-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PLeVasseur
changed the title
felix91gr
left a comment
felix91gr
left a comment
There was a problem hiding this comment.
Sorry I'm late. These have been pretty hard weeks.
Anywho. I hope this helps @PLeVasseur
CONTRIBUTING.md
Outdated
| Follow the guidance given in the comment with the guideline on which | ||
| chapter to place the coding guideline. |
There was a problem hiding this comment.
I'm not sure what we mean here. What do we mean here? :)
There was a problem hiding this comment.
Attempted to clarify in: b012450
Let me know what you think ✌️
There was a problem hiding this comment.
https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/blob/b012450a6cdb9de0f03449b1f789ec32c359ca34/CONTRIBUTING.md#4-create-the-pr this is how it's rendered. I'm still a bit lost there
| [6) Contributor Applies Feedback on Issue](#6-contributor-applies-feedback-on-issue) | ||
| and | ||
| [7) Contributor Applies Regenerated Guideline to PR](#7-contributor-applies-regenerated-guideline-to-pr) |
There was a problem hiding this comment.
I think these should be sub-steps or perhaps they could be elided? I can check on this again tomorrow, but for today's me, they feel like they're like step 5.2 that got accidentally promoted to main steps :)
PLeVasseur
force-pushed
the
feat/document-new-contribution-workflow
branch
from
8de045b to
72efde1
Compare
Co-authored-by: Félix Fischer <felix91gr@users.noreply.github.com>
Co-authored-by: Félix Fischer <felix91gr@users.noreply.github.com>
Co-authored-by: Félix Fischer <felix91gr@users.noreply.github.com>
Co-authored-by: Félix Fischer <felix91gr@users.noreply.github.com>
Co-authored-by: Félix Fischer <felix91gr@users.noreply.github.com>
Co-authored-by: Félix Fischer <felix91gr@users.noreply.github.com>
3 participants
closes #224
Example of what the generated guideline looks like:
#246 (comment)