Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run some CI jobs on upstream only 2/2 #957

Closed
wants to merge 2 commits into from

Conversation

nils-werner
Copy link
Contributor

Sorry for the mess... This is an addendum to #956, I missed ci/clippy which also requires secrets (for caching I presume).

@simonsan
Copy link
Contributor

simonsan commented Nov 28, 2023

That is just a normal GitHub actions token, this is automatically available for CI runners.

I'll leave this open, if there is anything else to fix, but Clippy can (and should) stay activated.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@simonsan
Copy link
Contributor

Wait, the whole actions-rs organization is unmaintained. :/ So other actions are affected as well. This might need a bigger refactor in the CI. I'll close this and refactor it today. Sorry for the circumstances, but good that we figured it out this way.

@simonsan simonsan closed this Nov 29, 2023
@nils-werner
Copy link
Contributor Author

@simonsan
Copy link
Contributor

simonsan commented Nov 29, 2023

Yes, I was going through all of our organization's projects and replacing most of the actions-rs-actions. With actions-rs/audit-check being the only one's missing, as I'm researching, what to replace it with. If there are any recommendations, they are welcome. :)

EDIT: https://github.com/rustsec/audit-check

@simonsan
Copy link
Contributor

@nils-werner Thank you for the initiative, I updated all workflows and actions across the rustic-rs organization that involve a secrets.GITHUB_TOKEN to not run in forks and removed all actions from actions-rs as well. 👍🏽

@nils-werner
Copy link
Contributor Author

I can confirm, the jobs all run to completion now, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants