-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Allow building without self-update feature #975
Conversation
490afbb
to
c7572a3
Compare
I'm personally not a big fan of self-updating software, and I agree with the sentiment! I'm not sure though, we should completely build without it, the way I know it from e.g. dev@TowerPC:/mnt/c/Users/dailyuse> rustup self update
error: self-update is disabled for this build of rustup
error: you should probably use your system package manager to update rustup I like that more, so essentially being able to replace the command on build time with another implementation saying that it is being build without it and that there is a package manager involved. If we want, we could even make that configurable, so people can add their own message there via an environment variable or essentially just say that they could configure a package manager name (for people that have more than one on their system). That needs to be documented in the https://github.com/rustic-rs/dev-docs as well, then. |
Head branch was pushed to by a user without write access
eb8433e
to
a03e230
Compare
Okay, I changed it so the self-update subcommand is hidden and prints an error message when invoked. |
561bd1f
to
1d28d9b
Compare
Thank you for the PR! 🚀 And a happy new year! 🥂 |
Patch backported from rustic-rs/rustic#975
c.f. #1139 |
The self-update subcommand is undesirable if rustic is installed using the system package manager.