Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix clippy finding, update cargo-check-external-types toolchain #14

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

cpu
Copy link
Contributor

@cpu cpu commented May 29, 2024

👋 As promised, when cargo-check-external-types makes an update I'm opening PRs to fix the builds :-) This project also had a clippy finding that is fixed along the way.

Cargo: add missing x500 feature

This was being ref'd in oid_db.rs, producing a clippy error of the form:

error: unexpected `cfg` condition value: `x500`
   --> /home/runner/work/oid-registry/oid-registry/target/debug/build/oid-registry-fa6fec30f9e743c7/out/oid_db.rs:411:11
    |
411 |     #[cfg(feature = "x500")]
    |           ^^^^^^^^^^------
    |                     |
    |                     help: there is a expected value with a similar name: `"x509"`
    |
    = note: expected values for `feature` are: `crypto`, `default`, `kdf`, `ms_spc`, `nist_algs`, `pkcs1`, `pkcs12`, `pkcs7`, `pkcs9`, `registry`, `x509`, and `x962`

The solution seems simple: add the missing x500 feature.

ci: update cargo-check-external-types toolchain

The upstream project cut a 0.1.12 release that now pins Rust nightly-2024-05-01. This commit updates CI to match.

cpu added 2 commits May 29, 2024 17:28
This was being ref'd in `oid_db.rs`, producing a clippy error of the
form:

```
error: unexpected `cfg` condition value: `x500`
   --> /home/runner/work/oid-registry/oid-registry/target/debug/build/oid-registry-fa6fec30f9e743c7/out/oid_db.rs:411:11
    |
411 |     #[cfg(feature = "x500")]
    |           ^^^^^^^^^^------
    |                     |
    |                     help: there is a expected value with a similar name: `"x509"`
    |
    = note: expected values for `feature` are: `crypto`, `default`, `kdf`, `ms_spc`, `nist_algs`, `pkcs1`, `pkcs12`, `pkcs7`, `pkcs9`, `registry`, `x509`, and `x962`
```
The upstream project cut a 0.1.12 release that now pins Rust
nightly-2024-05-01. This commit updates CI to match.
@chifflier chifflier merged commit a3189cb into rusticata:master Aug 2, 2024
11 checks passed
@chifflier
Copy link
Member

Applied, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants