project CI refresh #8
Conversation
* Reformats to better support parameters. * Adds merge_group trigger for supporting queued merges. * Adds cron scheduled build.
The `actions-rs/clippy-check` action is archived and there isn't a clear alternative. Since clippy is already being run in `rust.yml` the right fix seems to be removing this extra workflow.
This better matches what other rusticata crates are using, and Rust 1.44 seems to be having issues fetching deps in CI: ``` Caused by: failed to load source for dependency `nom` Caused by: Unable to update registry `https://github.com/rust-lang/crates.io-index` Caused by: failed to fetch `https://github.com/rust-lang/crates.io-index` Caused by: bad packet length; class=Net (12) ```
``` warning: bound is defined in more than one place --> src/combinator.rs:76:47 | 76 | pub fn upgrade_error<I, O, E1: ParseError<I>, E2: ParseError<I>, F>( | ^^ ... 81 | E2: From<E1>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations = note: `#[warn(clippy::multiple_bound_locations)]` on by default ```
|
@chifflier This is the first PR following up from our conversation over in x509-parser. I figured the best approach would be to update one Rusticata project low in the dep tree and then once you approved of the changes, I can start updating all of the other repos. I wanted to avoid doing them all at once and then having to update many different PRs based on the review feedback. Hopefully these changes are uncontroversial, but I've done them commit-by-commit to make it easy to ammend/drop parts as req'd. |
There was a problem hiding this comment.
Wow, the patch is bigger than I thought!
Thanks a lot for working on this, the patch looks good to me. There are just minor comments, and an open question for the test feature matrix that can be important before copying the CI files to other crates
I also think the PR strategy is good (patching most depended crates first).
Puts generic bounds in the same order as the generic parameters are defined.
|
@chifflier Thanks for the review! 🚀 I think this is ready for merge when you're happy. I'll start updating other repos as I find the time with the goal to get through all of them in the next week or two. |
|
This all looks fine to me, thank you for the PR and for the replies. |
nomtypes