Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.24.2 release #225

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Prepare 0.24.2 release #225

merged 1 commit into from
Oct 26, 2023

Conversation

djc
Copy link
Member

@djc djc commented Oct 26, 2023

Someone asked for this privately in order to help avoid duplicate dependencies (in particular, webpki-roots).

Proposed release notes

  • Tweak behavior of enable_all_versions() based on enabled versions
  • Add AcceptorBuilder::with_acceptor() builder method

@djc djc requested a review from cpu October 26, 2023 14:28
@djc djc changed the title Bump version to 0.24.2 Prepare 0.24.2 release Oct 26, 2023
@cpu
Copy link
Member

cpu commented Oct 26, 2023

It might be nice to bring the semver check CI task to this repo. I gave the diff a once over and briefly paused on this visibility change. After seeing the context it was made in (unreachable pub), it seems OK but it also made me realize we're missing that CI guard rail here. Do you want to fold that into this branch or would it be helpful if I did that in a separate PR?

@djc
Copy link
Member Author

djc commented Oct 26, 2023

Would be great if you can submit a PR for that.

@djc djc merged commit 5ab99d9 into main Oct 26, 2023
18 checks passed
@djc djc deleted the prepare-0.24.2 branch October 26, 2023 14:40
@djc
Copy link
Member Author

djc commented Oct 26, 2023

Published to crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants