Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable rustls-platform-verifier for docs.rs #279

Merged
merged 2 commits into from
Sep 4, 2024
Merged

enable rustls-platform-verifier for docs.rs #279

merged 2 commits into from
Sep 4, 2024

Conversation

flisky
Copy link
Contributor

@flisky flisky commented Jul 11, 2024

No description provided.

cpu
cpu approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thank you!

@djc djc enabled auto-merge July 12, 2024 20:13
djc
djc reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- would you mind keeping them in alphabetic order?

In rustls we've made the jump to #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))], that would be even better to follow here, if you want to spend a little time on that.

@cpu cpu disabled auto-merge September 3, 2024 15:45
@flisky
Copy link
Contributor Author

flisky commented Sep 4, 2024

It seems doc_auto_cfg is already there in f9775bc by yourself, @djc:)

@djc djc added this pull request to the merge queue Sep 4, 2024
@djc
Copy link
Member

djc commented Sep 4, 2024

Okay, thanks for the sorting!

Merged via the queue into rustls:main with commit f8c2036 Sep 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flisky @djc @cpu