Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add certificate signing request #37

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

Tudyx
Copy link
Contributor

@Tudyx Tudyx commented Feb 14, 2024

In rcgen we would like to use the rustls_pemfile crate to parse certificates, private keys, CRLs and CSRs. This PR adds support for parsing CSRs, the last one needed.

This pull request provides rustls/rcgen#223 more details.

src/lib.rs Outdated Show resolved Hide resolved
@Tudyx Tudyx force-pushed the add_certificate_signing_request branch from 71de0cd to 81234d1 Compare February 15, 2024 11:18
@Tudyx Tudyx force-pushed the add_certificate_signing_request branch from 81234d1 to 8def505 Compare February 15, 2024 11:20
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpu cpu merged commit de3d0ae into rustls:main Feb 15, 2024
8 checks passed
@cpu
Copy link
Member

cpu commented Feb 15, 2024

I'll get started on a release with this change.

Edit: #38

@cpu cpu mentioned this pull request Feb 15, 2024
@cpu
Copy link
Member

cpu commented Feb 15, 2024

https://github.com/rustls/pemfile/releases/tag/v%2F2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants