Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows - add computer certs #22

Closed
LukeMauldin opened this issue May 14, 2021 · 2 comments
Closed

Windows - add computer certs #22

LukeMauldin opened this issue May 14, 2021 · 2 comments

Comments

@LukeMauldin
Copy link

Current code in windows.rs only loads certificates from the user store: https://github.com/ctz/rustls-native-certs/blob/main/src/windows.rs#L19
In our use case, we push certificates group Group Policy into the computer store. Would also recommend querying schannel::cert_store::CertStore::open_local_machine to include computer certificates in the results.

@djc
Copy link
Member

djc commented Oct 11, 2021

Would you mind submitting a PR for this?

@cpu
Copy link
Member

cpu commented Sep 17, 2024

I recommend folks with more nuanced requirements for Windows & local root certificates try rustls-platform-verifier. In addition to improved behaviour on Windows it allows more robust certificate validation on other platforms.

I believe there's limited interest in expanding the rustls-native-certs handling of Windows trust stores since the platform verifier crate offers a better experience across several dimensions.

@cpu cpu closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants