feat: rustls_platform_verifier::tls_config_with_provider #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbr
force-pushed
the
tls-config-with-provider
branch
from
3304d87 to
6aaa0fc
Compare
jbr
force-pushed
the
tls-config-with-provider
branch
3 times, most recently
from
dac8d15 to
0260659
Compare
cpu
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Good idea, thank you.
Would you mind updating the README installation and setup section to briefly mention this alongside the existing tls_config() coverage?
jbr
force-pushed
the
tls-config-with-provider
branch
3 times, most recently
from
88dd952 to
3751b71
Compare
jbr
force-pushed
the
tls-config-with-provider
branch
from
3751b71 to
652d61a
Compare
jbr
force-pushed
the
tls-config-with-provider
branch
from
652d61a to
e11ad0b
Compare
jbr
changed the title
cpu
approved these changes
Apr 9, 2024
complexspaces
approved these changes
Apr 9, 2024
|
This was included in v/0.3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary entry point for this crate
tls_configis quite convenient, but opting out of that in order to configure a crypto provider adds a bit more complexity and opportunity for misconfiguration. This PR offers a solution to "do whattls_configdoes, but with a crypto provider".based on #81