Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell checker pass #2053

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Spell checker pass #2053

merged 1 commit into from
Jul 24, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Jul 24, 2024

No description provided.

Copy link

rustls-benchmarking bot commented Jul 24, 2024

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3910700 3959311 48611 (1.24%) 3.84%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4460147 4484628 24481 (0.55%) 4.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8853521 8877273 23752 (0.27%) 1.05%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13788710 13757619 -31091 (-0.23%) 0.67%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2139805 2135809 -3996 (-0.19%) 0.84%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30617651 30670162 52511 (0.17%) 0.41%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3920404 3914317 -6087 (-0.16%) 0.26%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31129628 31081517 -48111 (-0.15%) 0.28%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30675713 30628378 -47335 (-0.15%) 0.35%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 33543361 33495297 -48064 (-0.14%) 0.50%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13392238 13373383 -18855 (-0.14%) 0.59%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46457742 46409349 -48393 (-0.10%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13771823 13785994 14171 (0.10%) 1.12%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31117300 31089927 -27373 (-0.09%) 0.36%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 33529415 33554053 24638 (0.07%) 0.60%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46444680 46472445 27765 (0.06%) 0.24%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32996258 33014384 18126 (0.05%) 0.69%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32918587 32934696 16109 (0.05%) 0.64%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58218623 58191894 -26729 (-0.05%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92684792 92657019 -27773 (-0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80627662 80604502 -23160 (-0.03%) 0.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3384385 3385179 794 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1919033 1919446 413 (0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2955622 2955112 -510 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3994566 3995231 665 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42254859 42260280 5421 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43929231 43934736 5505 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2226280 2226006 -274 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30630578 30627052 -3526 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43449334 43444376 -4958 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41879894 41875613 -4281 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2133297 2133512 215 (0.01%) 0.77%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30656218 30653393 -2825 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3380964 3381269 305 (0.01%) 0.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8867410 8866660 -750 (-0.01%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2232938 2233112 174 (0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4239223 4238917 -306 (-0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4677658 4677995 337 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92624669 92630996 6327 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3914692 3914437 -255 (-0.01%) 0.33%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 33518469 33516559 -1910 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4319701 4319924 223 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80499879 80503988 4109 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31095897 31094355 -1542 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42322972 42320977 -1995 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32979857 32981347 1490 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30669124 30670392 1268 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12185177 12185617 440 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1915675 1915743 68 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43931272 43929801 -1471 (-0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4251533 4251419 -114 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13741191 13741553 362 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2015296 2015246 -50 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31112744 31113499 755 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42271238 42272208 970 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41870399 41871316 917 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42319571 42318655 -916 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 33517615 33516906 -709 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43342733 43343623 890 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41807884 41808738 854 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 33550676 33550003 -673 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43933152 43933951 799 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4515694 4515772 78 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31115528 31115001 -527 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32979538 32980089 551 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13743939 13743733 -206 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32938800 32939289 489 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 33550576 33551066 490 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42254404 42255017 613 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92668324 92667020 -1304 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12179514 12179347 -167 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31132938 31132551 -387 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 44013468 44013995 527 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2949262 2949295 33 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2851933 2851902 -31 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46462388 46462857 469 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 44017582 44017167 -415 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4389482 4389523 41 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41796150 41796540 390 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11989621 11989514 -107 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46455030 46454657 -373 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 44017230 44016887 -343 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58211172 58210762 -410 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58172706 58173115 409 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35474083 35473851 -232 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41790303 41790033 -270 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68632962 68633357 395 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92629215 92629736 521 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46428707 46428963 256 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32938758 32938584 -174 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58213872 58214142 270 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80507892 80507520 -372 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43340903 43340709 -194 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58292501 58292249 -252 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92625211 92625592 381 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43440641 43440815 174 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46429063 46428900 -163 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80608155 80607879 -276 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30644142 30644039 -103 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58296018 58296210 192 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80516078 80515813 -265 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92671571 92671281 -290 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35471942 35472038 96 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43343162 43343274 112 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42336662 42336750 88 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80608070 80608210 140 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43444140 43444176 36 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46368474 46368508 34 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46451001 46451030 29 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4392828 4392830 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58296789 58296804 15 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41888875 41888885 10 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_ring_1.2_rsa_aes 1.66 ms 1.65 ms -0.01 ms (-0.55%) 2.48%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.24 ms 2.23 ms -0.01 ms (-0.43%) 2.97%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.38 ms 5.40 ms 0.02 ms (0.34%) 1.42%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.32 ms 6.35 ms 0.02 ms (0.34%) 1.18%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.09 ms 6.11 ms 0.02 ms (0.33%) 1.13%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.07 ms 2.06 ms -0.01 ms (-0.32%) 1.96%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.39 ms 6.41 ms 0.02 ms (0.30%) 1.30%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 483.24 µs 484.65 µs 1.41 µs (0.29%) 2.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.16 ms 6.18 ms 0.02 ms (0.29%) 1.71%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.39 ms 5.40 ms 0.01 ms (0.28%) 1.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.45 ms 5.46 ms 0.01 ms (0.27%) 1.54%
handshake_session_id_ring_1.2_rsa_aes 1.57 ms 1.56 ms -0.00 ms (-0.26%) 2.41%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.15 ms 6.17 ms 0.02 ms (0.25%) 1.58%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.40 ms 6.41 ms 0.01 ms (0.23%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.11 ms 6.12 ms 0.01 ms (0.22%) 1.51%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.44 ms 5.45 ms 0.01 ms (0.22%) 1.61%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.79 ms 6.77 ms -0.01 ms (-0.21%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.34 ms 6.35 ms 0.01 ms (0.20%) 1.09%
handshake_tickets_ring_1.3_ecdsap256_aes 6.83 ms 6.81 ms -0.01 ms (-0.19%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 995.31 µs 993.68 µs -1.63 µs (-0.16%) 1.02%
handshake_tickets_ring_1.3_rsa_aes 7.30 ms 7.29 ms -0.01 ms (-0.14%) 1.00%
transfer_no_resume_ring_1.2_rsa_aes 6.79 ms 6.78 ms -0.01 ms (-0.14%) 2.74%
transfer_no_resume_ring_1.3_rsa_aes 6.86 ms 6.85 ms -0.01 ms (-0.14%) 2.48%
handshake_tickets_ring_1.3_ecdsap384_aes 9.90 ms 9.89 ms -0.01 ms (-0.13%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.42 ms 1.42 ms 0.00 ms (0.12%) 5.63%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.38 ms 6.37 ms -0.01 ms (-0.11%) 2.66%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.48 ms 9.47 ms -0.01 ms (-0.09%) 1.97%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.41 ms 0.00 ms (0.09%) 6.07%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.47 ms 5.47 ms -0.00 ms (-0.07%) 3.52%
transfer_no_resume_ring_1.3_rsa_chacha 13.51 ms 13.50 ms -0.01 ms (-0.05%) 1.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 484.26 µs 484.02 µs -0.24 µs (-0.05%) 2.56%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.20 ms 1.20 ms 0.00 ms (0.05%) 1.02%
handshake_no_resume_ring_1.3_rsa_aes 992.47 µs 992.04 µs -0.43 µs (-0.04%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.81 ms 9.82 ms 0.00 ms (0.04%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.21 ms 7.22 ms 0.00 ms (0.04%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.73 ms 6.73 ms 0.00 ms (0.04%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.76 ms 6.76 ms -0.00 ms (-0.04%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 508.22 µs 508.38 µs 0.16 µs (0.03%) 2.42%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.73 ms 13.73 ms 0.00 ms (0.03%) 1.21%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.86 ms 9.86 ms -0.00 ms (-0.03%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.61 ms 0.00 ms (0.03%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.26 ms 7.25 ms -0.00 ms (-0.03%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.49 ms 5.49 ms -0.00 ms (-0.02%) 3.74%
handshake_session_id_ring_1.3_rsa_aes 7.25 ms 7.25 ms -0.00 ms (-0.02%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.20 ms 1.20 ms 0.00 ms (0.02%) 1.35%
handshake_no_resume_ring_1.2_rsa_aes 991.82 µs 991.98 µs 0.16 µs (0.02%) 1.06%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.55 ms 4.55 ms 0.00 ms (0.02%) 4.56%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.00 ms 13.00 ms 0.00 ms (0.01%) 1.49%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms -0.00 ms (-0.01%) 6.18%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.01%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.11 ms 16.11 ms 0.00 ms (0.01%) 1.28%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.02 ms 13.02 ms 0.00 ms (0.01%) 1.53%
handshake_session_id_ring_1.3_ecdsap384_aes 9.84 ms 9.84 ms 0.00 ms (0.00%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 511.66 µs 511.68 µs 0.02 µs (0.00%) 2.17%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.94 ms 13.94 ms -0.00 ms (-0.00%) 1.80%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.27 ms 5.27 ms -0.00 ms (-0.00%) 3.80%

Additional information

Historical results

Checkout details:

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (127a0a7) to head (caa7e47).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2053   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files          97       97           
  Lines       21914    21914           
=======================================
  Hits        20664    20664           
  Misses       1250     1250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz enabled auto-merge July 24, 2024 14:40
@ctz ctz added this pull request to the merge queue Jul 24, 2024
Merged via the queue into main with commit ceb5e39 Jul 24, 2024
46 checks passed
@ctz ctz deleted the jbp-spelling branch July 24, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants