Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bogo #2146

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Update bogo #2146

merged 3 commits into from
Oct 3, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Oct 3, 2024

This takes the current version of bogo, which adds testing of ML-KEM.

At the same time, there are some improved tests for alerts sent on key exchange failure.

ctz added 3 commits October 3, 2024 16:18
@ctz
Send illegal_parameter alert on invalid key share
8533c28 
For client::tls12, ensure the alert is sent prior to -- instead of --
the CCS.  This means the peer can read it.
@ctz
Send illegal_parameter alert on illegal group
f1c3d4e 
We had a specific error for this eventuality, but didn't
send an alert for it.
@ctz
Take latest bogo release
7e89129 
- widen configuration preventing P-521 key exchange
- opt-out of cnsa profile testing
- support new error for invalid key share
- opt-out of ML-KEM tests (for now)
@ctz ctz force-pushed the jbp-update-bogo branch from 8804e03 to 7e89129 Compare October 3, 2024 15:18
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Oct 3, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8617117 8587094 -30023 (-0.35%) 1.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10829029 10798733 -30296 (-0.28%) 0.82%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1665955 1670352 4397 (0.26%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8618683 8597260 -21423 (-0.25%) 0.56%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10801972 10781473 -20499 (-0.19%) 1.15%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3621512 3625578 4066 (0.11%) 0.43%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3084083 3081602 -2481 (-0.08%) 0.28%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10416799 10408644 -8155 (-0.08%) 0.84%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3622688 3624742 2054 (0.06%) 0.33%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46440953 46452479 11526 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3087124 3086544 -580 (-0.02%) 0.28%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873055 3873595 540 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3877503 3878043 540 (0.01%) 2.29%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4215529 4216069 540 (0.01%) 0.21%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5001304 5001844 540 (0.01%) 1.95%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1283761 1283632 -129 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1281415 1281293 -122 (-0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236699 4236339 -360 (-0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4238350 4237990 -360 (-0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497603 4497243 -360 (-0.01%) 0.22%
handshake_tickets_ring_1.2_rsa_aes_server 4682247 4681887 -360 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2176801 2176642 -159 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717503 1717572 69 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32079158 32080303 1145 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32076151 32077249 1098 (0.00%) 0.30%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32132304 32133343 1039 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32079297 32080332 1035 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34143673 34144763 1090 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32132226 32133244 1018 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34137832 34138848 1016 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656090 2656167 77 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2661933 2662010 77 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34134970 34135939 969 (0.00%) 0.50%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34141096 34142064 968 (0.00%) 0.23%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34143882 34144818 936 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32129317 32130191 874 (0.00%) 0.50%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34137952 34138877 925 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43198013 43199003 990 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43200906 43201896 990 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43200929 43201919 990 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43307843 43308833 990 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43310736 43311726 990 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43310759 43311749 990 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43870314 43871304 990 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43873671 43874661 990 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43873672 43874662 990 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43963104 43964094 990 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43966461 43967451 990 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43966462 43967452 990 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1667355 1667388 33 (0.00%) 1.01%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925871 1925907 36 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563546 2563586 40 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2173679 2173712 33 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932592 1932621 29 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58258153 58257512 -641 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30725886 30726200 314 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30311577 30311866 289 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30726141 30725931 -210 (-0.00%) 0.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30348499 30348677 178 (0.00%) 0.47%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7617099 7617142 43 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7619276 7619309 33 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30760074 30760203 129 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41708786 41708906 120 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41709292 41709412 120 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41723022 41723142 120 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11475340 11475373 33 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11481319 11481352 33 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41797496 41797616 120 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41798002 41798122 120 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41811732 41811852 120 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42170243 42170363 120 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42170769 42170889 120 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42184720 42184840 120 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42244037 42244157 120 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42244479 42244599 120 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42258514 42258634 120 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30312218 30312290 72 (0.00%) 0.47%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30760057 30760129 72 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30362327 30362385 58 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30782515 30782560 45 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183027 35183073 46 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11291771 11291757 -14 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30326348 30326379 31 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35184935 35184964 29 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30748459 30748484 25 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30347747 30347739 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46476497 46476507 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46489372 46489362 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58356602 58356613 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46464445 46464451 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80560692 80560701 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80667603 80667612 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92722951 92722960 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80671130 80671123 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46479175 46479179 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58255276 58255281 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68687124 68687120 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92716720 92716716 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80646205 80646208 3 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58239129 58239131 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92686930 92686933 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92718955 92718952 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80546266 80546264 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46395837 46395836 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46484567 46484568 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58345702 58345701 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58352847 58352846 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92677868 92677867 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92688769 92688768 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80547649 80547649 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46492222 46492222 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58260230 58260230 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.57 ms 4.48 ms -0.09 ms (-1.96%) 5.65%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.37 ms 1.40 ms 0.02 ms (1.78%) 4.15%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.43 ms 0.02 ms (1.77%) 4.08%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.40 ms 1.42 ms 0.02 ms (1.74%) 4.67%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.30 ms 5.21 ms -0.09 ms (-1.67%) 4.52%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.92 ms 1.95 ms 0.03 ms (1.52%) 4.81%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.43 ms 6.33 ms -0.09 ms (-1.43%) 3.18%
transfer_no_resume_ring_1.3_rsa_aes 6.93 ms 6.83 ms -0.09 ms (-1.35%) 3.84%
transfer_no_resume_ring_1.2_rsa_aes 6.85 ms 6.76 ms -0.09 ms (-1.28%) 3.18%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 464.77 µs 459.55 µs -5.23 µs (-1.12%) 3.15%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.55 ms 5.49 ms -0.06 ms (-1.09%) 4.76%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.53 ms 5.47 ms -0.06 ms (-1.06%) 5.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 465.78 µs 460.89 µs -4.89 µs (-1.05%) 4.22%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.09 ms 2.11 ms 0.02 ms (1.00%) 4.17%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.53 ms 9.43 ms -0.09 ms (-0.98%) 2.25%
handshake_no_resume_ring_1.3_ecdsap256_chacha 505.49 µs 500.60 µs -4.89 µs (-0.97%) 2.77%
transfer_no_resume_ring_1.3_rsa_chacha 13.57 ms 13.47 ms -0.10 ms (-0.76%) 1.77%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.07 ms 12.97 ms -0.10 ms (-0.74%) 1.56%
handshake_no_resume_ring_1.3_ecdsap256_aes 507.84 µs 504.18 µs -3.66 µs (-0.72%) 3.03%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.76 ms 13.67 ms -0.09 ms (-0.68%) 1.60%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.04 ms 12.95 ms -0.09 ms (-0.68%) 1.72%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.17 ms 16.07 ms -0.10 ms (-0.64%) 1.33%
handshake_tickets_ring_1.3_ecdsap256_aes 6.70 ms 6.65 ms -0.04 ms (-0.64%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.60 ms -0.01 ms (-0.63%) 2.72%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.17 ms -0.01 ms (-0.63%) 1.72%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.67 ms 5.64 ms -0.03 ms (-0.61%) 2.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.17 ms -0.01 ms (-0.61%) 1.82%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.64 ms 6.60 ms -0.04 ms (-0.60%) 1.18%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.01 ms (-0.58%) 2.30%
handshake_tickets_ring_1.3_rsa_chacha 7.13 ms 7.09 ms -0.04 ms (-0.54%) 1.23%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.67 ms 5.64 ms -0.03 ms (-0.54%) 2.30%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.62 ms 4.59 ms -0.02 ms (-0.53%) 2.33%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.96 ms 4.94 ms -0.03 ms (-0.53%) 2.68%
handshake_no_resume_ring_1.3_rsa_aes 1.00 ms 0.99 ms -0.01 ms (-0.52%) 1.13%
handshake_tickets_ring_1.3_rsa_aes 7.18 ms 7.14 ms -0.04 ms (-0.50%) 1.36%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.95 ms 4.93 ms -0.02 ms (-0.50%) 2.91%
handshake_tickets_ring_1.3_ecdsap384_aes 9.78 ms 9.73 ms -0.05 ms (-0.47%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.73 ms 9.68 ms -0.04 ms (-0.46%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.57 ms 6.54 ms -0.03 ms (-0.45%) 1.58%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.52 ms 6.49 ms -0.03 ms (-0.45%) 1.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.33 ms 5.30 ms -0.02 ms (-0.44%) 2.10%
handshake_session_id_ring_1.3_rsa_chacha 7.01 ms 6.98 ms -0.03 ms (-0.44%) 1.36%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.00 ms 13.94 ms -0.06 ms (-0.43%) 1.84%
handshake_session_id_ring_1.3_rsa_aes 7.06 ms 7.03 ms -0.03 ms (-0.42%) 1.45%
handshake_no_resume_ring_1.3_rsa_chacha 999.70 µs 995.68 µs -4.02 µs (-0.40%) 1.27%
handshake_session_id_ring_1.3_ecdsap384_aes 9.65 ms 9.62 ms -0.04 ms (-0.38%) 1.05%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.61 ms 9.58 ms -0.04 ms (-0.37%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.61 ms 4.60 ms -0.02 ms (-0.36%) 2.43%
handshake_no_resume_ring_1.2_rsa_aes 993.38 µs 989.88 µs -3.50 µs (-0.35%) 1.11%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.57 ms 5.59 ms 0.02 ms (0.32%) 2.80%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.33 ms 5.31 ms -0.02 ms (-0.29%) 1.83%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms -0.01 ms (-0.18%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.60 ms -0.00 ms (-0.13%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.92 ms 5.92 ms 0.01 ms (0.10%) 2.96%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.90 ms 5.91 ms 0.00 ms (0.07%) 2.84%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.56 ms 5.57 ms 0.00 ms (0.07%) 2.31%

Additional information

Historical results

Checkout details:

@djc
Copy link
Member

djc commented Oct 3, 2024

Nice!

@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (2d3b7ab) to head (7e89129).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2146      +/-   ##
==========================================
+ Coverage   94.63%   94.66%   +0.02%     
==========================================
  Files         102      102              
  Lines       23408    23434      +26     
==========================================
+ Hits        22153    22183      +30     
+ Misses       1255     1251       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cpu
cpu approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, 🚀

@djc djc added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 0560938 Oct 3, 2024
60 checks passed
@djc djc deleted the jbp-update-bogo branch October 3, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu