Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown fixes in manual #2169

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Markdown fixes in manual #2169

merged 2 commits into from
Oct 21, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Oct 21, 2024

The table in tlsvulns has not rendered for a while now, due to a downstream change. However the table wasn't correct anyway and was missing a column.

(The source didn't change between these points.)

The links I added in #2145 are broken in an embarrassing way.

Copy link

rustls-benchmarking bot commented Oct 21, 2024

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8600032 8569703 -30329 (-0.35%) 1.09%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10735435 10761153 25718 (0.24%) 1.11%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8597485 8590570 -6915 (-0.08%) 0.61%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10446851 10452717 5866 (0.06%) 1.33%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10737344 10731634 -5710 (-0.05%) 0.81%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3086835 3085519 -1316 (-0.04%) 0.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3084442 3085145 703 (0.02%) 0.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2105758 2105665 -93 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348747 58350415 1668 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623427 3623328 -99 (-0.00%) 0.45%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1639761 1639725 -36 (-0.00%) 1.03%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1641126 1641154 28 (0.00%) 1.05%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3622881 3622932 51 (0.00%) 0.33%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30585759 30585377 -382 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925967 1925982 15 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 30073792 30073607 -185 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1208515 1208522 7 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32429801 32429629 -172 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30203939 30204070 131 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717456 1717449 -7 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30598952 30599071 119 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2108693 2108686 -7 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32423345 32423450 105 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30585392 30585489 97 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30621453 30621359 -94 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 30023361 30023279 -82 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30167934 30167856 -78 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 30023618 30023543 -75 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30182483 30182555 72 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32426647 32426575 -72 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32426148 32426217 69 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 30020636 30020698 62 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30168445 30168385 -60 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30598915 30598970 55 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30607812 30607866 54 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 30073815 30073867 52 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 30070838 30070876 38 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30204633 30204663 30 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32426692 32426663 -29 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32429496 32429515 19 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7594190 7594194 4 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183232 35183249 17 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30218529 30218517 -12 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470692 46470682 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487102 46487092 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46467116 46467125 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467811 46467802 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46434718 46434711 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58251822 58251815 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68684449 68684443 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92712623 92712615 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92718852 92718860 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661845 80661851 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58256134 58256130 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46480096 46480099 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92714855 92714860 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540447 80540451 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641256 80641260 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46460136 46460138 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648884 80648887 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682833 92682836 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535650 80535648 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389596 46389597 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58341600 58341601 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58352503 58352502 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554935 80554936 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684671 92684672 1 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662156 2662156 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41585022 41585022 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41570796 41570796 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 42644903 42644903 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43380481 43380481 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873505 3873505 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 42558797 42558797 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 42556178 42556178 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236849 4236849 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43377336 43377336 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43317546 43317546 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42080791 42080791 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7596368 7596368 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4215859 4215859 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41571286 41571286 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11458465 11458465 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58254055 58254055 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58237089 58237089 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41640486 41640486 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42095258 42095258 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 42647511 42647511 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43320665 43320665 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43320661 43320661 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 42558786 42558786 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11452485 11452485 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35185162 35185162 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656291 2656291 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43380455 43380455 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 42647477 42647477 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3890151 3890151 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563539 2563539 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932688 1932688 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41654712 41654712 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673769 92673769 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42081331 42081331 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4693723 4693723 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1210791 1210791 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42039031 42039031 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4250659 4250659 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012225 5012225 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42039553 42039553 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292296 11292296 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497633 4497633 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42053498 42053498 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41640994 41640994 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 459.20 µs 456.29 µs -2.92 µs (-0.64%) 4.32%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms 0.00 ms (0.25%) 1.58%
handshake_session_id_ring_1.3_rsa_chacha 6.96 ms 6.98 ms 0.02 ms (0.25%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.11 ms 7.13 ms 0.02 ms (0.24%) 1.04%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.47 ms 6.48 ms 0.02 ms (0.24%) 1.13%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.50 ms 4.49 ms -0.01 ms (-0.23%) 1.92%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.59 ms 6.60 ms 0.01 ms (0.22%) 1.13%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.11 ms 5.10 ms -0.01 ms (-0.21%) 3.85%
transfer_no_resume_ring_1.2_rsa_aes 6.76 ms 6.75 ms -0.01 ms (-0.20%) 3.31%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.17 ms 5.16 ms -0.01 ms (-0.20%) 4.08%
handshake_tickets_ring_1.3_ecdsap256_aes 6.62 ms 6.63 ms 0.01 ms (0.19%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.44 ms 4.43 ms -0.01 ms (-0.19%) 5.08%
handshake_tickets_ring_1.3_rsa_chacha 7.08 ms 7.09 ms 0.01 ms (0.17%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.21 ms 5.20 ms -0.01 ms (-0.17%) 1.76%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.14 ms 5.13 ms -0.01 ms (-0.16%) 3.54%
handshake_session_id_ring_1.3_ecdsap256_aes 6.51 ms 6.52 ms 0.01 ms (0.16%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.12 ms 1.12 ms -0.00 ms (-0.15%) 8.77%
handshake_session_id_ring_1.3_rsa_aes 7.00 ms 7.01 ms 0.01 ms (0.14%) 1.01%
handshake_no_resume_ring_1.3_ecdsap256_aes 502.81 µs 503.49 µs 0.68 µs (0.14%) 3.18%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.55 ms 5.54 ms -0.01 ms (-0.13%) 1.70%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.17 ms 5.17 ms -0.01 ms (-0.12%) 1.94%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.80 ms 1.80 ms 0.00 ms (0.12%) 5.46%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.49 ms 5.49 ms -0.01 ms (-0.12%) 2.41%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 454.55 µs 455.08 µs 0.52 µs (0.12%) 3.96%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.34 ms 6.33 ms -0.01 ms (-0.11%) 3.60%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.00 ms (-0.11%) 1.87%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.67 ms 9.68 ms 0.01 ms (0.10%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 991.50 µs 990.47 µs -1.03 µs (-0.10%) 1.27%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.55 ms 9.56 ms 0.01 ms (0.10%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.08 ms 1.08 ms -0.00 ms (-0.10%) 8.09%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.64 ms 13.63 ms -0.01 ms (-0.10%) 1.53%
transfer_no_resume_ring_1.3_rsa_aes 6.84 ms 6.83 ms -0.01 ms (-0.10%) 3.03%
handshake_tickets_ring_1.3_ecdsap384_aes 9.70 ms 9.71 ms 0.01 ms (0.09%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.44 ms 13.43 ms -0.01 ms (-0.08%) 1.57%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.53 ms 5.53 ms -0.00 ms (-0.07%) 1.55%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.50 ms 5.51 ms 0.00 ms (0.07%) 2.08%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms -0.00 ms (-0.07%) 1.49%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.63 ms 1.63 ms -0.00 ms (-0.06%) 5.28%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.03 ms -0.01 ms (-0.06%) 1.25%
handshake_no_resume_ring_1.3_rsa_aes 994.39 µs 995.01 µs 0.62 µs (0.06%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 499.54 µs 499.25 µs -0.28 µs (-0.06%) 3.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.82 ms 4.81 ms -0.00 ms (-0.06%) 1.99%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.95 ms 12.94 ms -0.01 ms (-0.06%) 1.67%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.18 ms 5.18 ms -0.00 ms (-0.05%) 1.22%
handshake_no_resume_ring_1.3_rsa_chacha 994.33 µs 994.86 µs 0.53 µs (0.05%) 1.30%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.91 ms 12.91 ms -0.01 ms (-0.05%) 1.96%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.17 ms -0.00 ms (-0.04%) 1.35%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.81 ms 4.81 ms -0.00 ms (-0.04%) 1.59%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.44 ms 9.43 ms -0.00 ms (-0.04%) 1.98%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.47 ms 4.47 ms 0.00 ms (0.03%) 1.39%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.16 ms 5.17 ms 0.00 ms (0.03%) 2.42%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.60 ms 13.60 ms -0.00 ms (-0.02%) 1.40%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.12 ms 0.00 ms (0.02%) 9.22%
handshake_session_id_ring_1.3_ecdsap384_aes 9.59 ms 9.59 ms 0.00 ms (0.02%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.59 ms 3.60 ms 0.00 ms (0.02%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.59 ms -0.00 ms (-0.01%) 1.00%

Additional information

Historical results

Checkout details:

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (9249b61) to head (37aecaa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2169   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         102      102           
  Lines       23748    23748           
=======================================
  Hits        22493    22493           
  Misses       1255     1255           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 3890cd7 Oct 21, 2024
60 checks passed
@ctz ctz deleted the jbp-manual-markdown-fixes branch October 21, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants