No shutdown raw stream #102
Open
+70
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quininer
force-pushed
the
quininer/no-shutdown
branch
from
28eaa4d to
efa87f5
Compare
|
Can you extend the PR description with some context? Why is this the best path forward? |
|
I mentioned it here. if there is a consensus, I will add more information in comments later. |
|
It seems surprising to not shutdown the TCP socket if |
|
I think the most sensible default is to shutdown the TLS and TCP connections. Perhaps we could have an explicit and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #64