Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take rustls 0.23 #44

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Take rustls 0.23 #44

merged 2 commits into from
Mar 5, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Feb 29, 2024

  • Track new alert-sending API for Acceptor.

nb. I have quite little experience in this codebase and not much confidence with async generally, so please give this a detailed look.

src/common/mod.rs Show resolved Hide resolved
Copy link
Contributor

@paolobarbolini paolobarbolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't default features change to aws-lc-rs here too?
Also it looks like in rustls the feature name is aws_lc_rs, not aws-lc-rs

Copy link
Member

@quininer quininer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GlenDC
Copy link
Contributor

GlenDC commented Mar 4, 2024

LGTM as well

@djc djc merged commit 0587801 into main Mar 5, 2024
6 checks passed
@djc djc deleted the jbp-rustls-0.23 branch March 5, 2024 09:48
@cpu cpu mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants