Fix: Check for ErrorKind::WouldBlock in LazyConfigAcceptor #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2024
djc
approved these changes
Mar 6, 2024
|
Since this seems a little finicky, could you add a test? |
jbr
force-pushed
the
send-alert-would-block-in-lazy-config-acceptor
branch
from
2143357
to
263fd4b
Compare
|
Good call with the test, the original implementation didn't handle the possibility that the write buffer was too small to fit the whole alert |
jbr
force-pushed
the
send-alert-would-block-in-lazy-config-acceptor
branch
from
263fd4b
to
f8fd742
Compare
This was referenced Mar 6, 2024
djc
approved these changes
Mar 7, 2024
|
(Needs a rebase now.) |
jbr
force-pushed
the
send-alert-would-block-in-lazy-config-acceptor
branch
from
f8fd742
to
a981580
Compare
|
Rebased |
|
Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #47