Move revocation cache #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
force-pushed
the
revocation-cache
branch
2 times, most recently
from
545f530 to
8662a71
Compare
ctz
approved these changes
Jan 5, 2026
| pub(super) async fn fetch(dry_run: bool, config: &Config) -> Result<ExitCode, Report> { | ||
| use crate::{Config, Filter, Manifest}; | ||
|
|
||
| pub async fn fetch(dry_run: bool, config: &Config) -> Result<ExitCode, Report> { |
Member
There was a problem hiding this comment.
Are we missing a lint here for undocumented pub items?
Member
|
I think it's more constructive to merge this before #29? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
cache_dirshould actually be in the top-levelConfig, since it is upki-wide (that is, not just limited to revocation in the future). Includes a bunch of further librarification to make this a bit nicer.