-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 32 bit support, add i686-unknown-linux-gnu CI target #113
Conversation
Codecov Report
@@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 15 15
Lines 3346 3346
=======================================
Hits 3191 3191
Misses 155 155
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
with: | ||
persist-credentials: false | ||
- uses: dtolnay/rust-toolchain@nightly | ||
- run: cargo install cross |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: This seems to add about a minute to the CI runtime. Do you think its worth caching the install or using cargo-binstall for a pre-compiled version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hesitant to add any 3rd party actions since I think the project has taken a pretty conservative stance on those in the past.
I'm not familiar with cargo-binstall
but it does sound interesting. Maybe we could consider the speed optimizations in a follow-up once the breakage is addressed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like https://github.com/marketplace/actions/install-development-tools would maybe be the best way to integrate (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "is this secure" part of the FAQ (https://github.com/cargo-bins/cargo-binstall#faq) gives me some pause :-/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Their description doesn't seem horribly problematic (they go from crates.io -> GitHub), but its probably not worth the 1 minute of CI time then if we're both slightly hesitant. I was hoping there was a more clear answer for pre-compiled binaries.
085294f
to
0f0c601
Compare
Tacked on a version bump commit with the assumption we'll want to turn around a |
2f0f420
to
5aa57e9
Compare
I will do a second release prep checkist PR afterwards with a README changelog update. |
I think this can be 0.101.1 instead of 0.102.0? No semver compatibility was hurt in this PR. |
Oops, you're right. Fixing. |
Prepare for a release that includes the 32bit arch fix.
5aa57e9
to
d4aa00a
Compare
Merging this since I'd like to get the issue solved ASAP. If @ctz has further refinements in mind I will chase them separately. |
|
ci: add a 32bit target build w/ cross.
This commit introduces a CI target that uses cross to cross-compile for a
i686-unknown-linux-gnu
target to ensure we maintain 32bit arch compatibility. Unfortunately I don't believe GitHub actions has a native 32bit runner so cross-compilation is our best bet.Before applying the subsequent fix commit this task fails with the error reported in #112:
der: fix DER max size constants for 32bit targets.
This commit introduces a fix to the
LONG_FORM_LEN_XXX_BYTES_MAX
constants in theder
module to avoid overflow on 32bit targets.Resolves #112
cargo: bump version to 0.101.1
Prepare for a release that includes the 32bit arch fix.