Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crl/signed_data: add Debug and Clone as sensible. #129

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

cpu
Copy link
Member

@cpu cpu commented Jul 19, 2023

This branch adds derived Debug traits to:

  • BorrowedCertRevocationList
  • BorrowedRevokedCert
  • RevokedCerts
  • SignedData
  • OwnedCertRevocationList
  • OwnedRevokedCert
  • OwnedSignedData

It additionally adds derived Clone traits to:

  • OwnedCertRevocationList
  • OwnedRevokedCert
  • OwnedSignedData

Verified

This commit was signed with the committer’s verified signature.
cpu Daniel McCarney
This commit adds derived `Debug` traits to:

* `BorrowedCertRevocationList`
* `BorrowedRevokedCert`
* `RevokedCerts`
* `SignedData`
* `OwnedCertRevocationList`
* `OwnedRevokedCert`
* `OwnedSignedData`

It additionally adds derived `Clone` traits to:

* `OwnedCertRevocationList`
* `OwnedRevokedCert`
* `OwnedSignedData`
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #129 (bede3b0) into main (3313270) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   95.69%   95.73%   +0.04%     
==========================================
  Files          15       15              
  Lines        3346     3379      +33     
==========================================
+ Hits         3202     3235      +33     
  Misses        144      144              
Impacted Files Coverage Δ
src/crl.rs 100.00% <100.00%> (ø)
src/signed_data.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cpu cpu force-pushed the cpu-crls-clone-and-debug branch from b02da51 to 2ffb314 Compare July 19, 2023 20:37

Verified

This commit was signed with the committer’s verified signature.
cpu Daniel McCarney
This will help prevent any regressions and increases our overall
coverage.
@cpu cpu force-pushed the cpu-crls-clone-and-debug branch from 2ffb314 to bede3b0 Compare July 19, 2023 20:39
@cpu
Copy link
Member Author

cpu commented Jul 19, 2023

cpu force-pushed the cpu-crls-clone-and-debug branch from 2ffb314 to bede3b0

I wanted to fix the coverage decrease (and prevent regressions) so I added some quick test coverage in bede3b0 (after some flailing around to fix the no-alloc builds 😓).

@djc Do you want to take another peek? Thanks 🙇

@cpu cpu added this pull request to the merge queue Jul 19, 2023
Merged via the queue into rustls:main with commit febe409 Jul 19, 2023
@cpu cpu deleted the cpu-crls-clone-and-debug branch July 19, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants