Take aws-lc-rs 1.9 #284
Merged
Take aws-lc-rs 1.9 #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires a manual bump of cc to 1.0.100. Upstream PR opened to fix that.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
- Coverage 97.33% 97.23% -0.11%
==========================================
Files 20 20
Lines 4283 4225 -58
==========================================
- Hits 4169 4108 -61
- Misses 114 117 +3 ☔ View full report in Codecov by Sentry. |
cpu
approved these changes
Sep 9, 2024
third-party/chromium/data/verify_signed_data/ours/ecdsa-prime256v1-sha256-spki-inside-spki.pem
Outdated
Show resolved
Hide resolved
ctz
force-pushed
the
jbp-aws-lc-rs-1.9
branch
2 times, most recently
from
1c0c2aa to
7e52a29
Compare
djc
approved these changes
Sep 9, 2024
What if the SPKI BIT STRING contains a SPKI? This test aims to find out. It is a regression test for the code that restricts EC key encodings being lost, as aws-lc-rs accepts an SPKI in the API we use.
ctz
force-pushed
the
jbp-aws-lc-rs-1.9
branch
from
7e52a29 to
123fc3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed release notes:
(nb. I plan to enable the
prebuilt-nasmfeature at the rustls level, not here. Mainly because this crate has a slower release cadence and it seems like a good idea to make that decision as high in the stack as possible.)