tests: further cleanup/generalization. #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also switch to using named arguments and sensible defaults when omitted.
Previously there was a lot of duplicated path constants (e.g. "name_constraints/"). We were also doing path manipulation in both Python and Rust code. This commit removes the duplication by introducing more variables. It also lifts all of the path manipulation to the Python code and switches to `os.path.join` instead of raw string bashing.
This allows choosing which test cases are generated, whether to run cargo fmt, and whether to run cargo test. By default all tests are generated and both cargo commands are run, matching pre-existing behaviour. These flags are helpful when developing new test cases as it allows iterating on a subset without as much churn in the tree.
The top header comment for generate.py was overly specific to the name constraint test generation. This commit updates it to reflect the current state of the script.
In future tests we will be generating intermediate issuers and so it's helpful to differentiate the root trust anchor's private/public key from other issuers in a certificate chain.
This commit adds two optional arguments to `ca_cert` to allow specifying an issuer name and private key as opposed to always generating an issuer certificate that is self-issued. This will allow the `ca_cert` helper to be used to make longer certificate chains. Similarly, a new argument to optionally provide an `x509.KeyUsage` is added. This will allow generating issuer certificates that assert different usage bits (e.g. including/excluding cRLSign).
djc
approved these changes
May 26, 2023
It might be doable using
Noted. Will try to break things up even further in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch follows #64 and introduces a few more helpful generalizations/cleanups that I made while writing CRL focused test cases.
Some highlights:
cargo fmtandcargo testinvocations are run post-generation.These changes do not affect the generated test cases so I haven't committed updated test files. We know the generator script + the test cases it spits out still work thanks to the CI improvements that landed in #64 :-)