Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment character so that specific compilers don't break #76

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Fix comment character so that specific compilers don't break #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions pqcrypto-internals/cfiles/keccak2x/feat.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ SOFTWARE.
#if (__APPLE__ && __ARM_FEATURE_CRYPTO) || (__ARM_FEATURE_SHA3)

.macro round
; Execute theta, but without xoring into the state yet.
; Compute parities p[i] = a[i] ^ a[5+i] ^ ... ^ a[20+i].
// Execute theta, but without xoring into the state yet.
// Compute parities p[i] = a[i] ^ a[5+i] ^ ... ^ a[20+i].
eor3.16b v25, v0, v5, v10
eor3.16b v26, v1, v6, v11
eor3.16b v27, v2, v7, v12
Expand All @@ -41,14 +41,14 @@ SOFTWARE.
eor3.16b v28, v28, v18, v23
eor3.16b v29, v29, v19, v24

rax1.2d v30, v29, v26 ; d[0] = rotl(p[1], 1) ^ p[4]
rax1.2d v29, v27, v29 ; d[3] = rotl(p[4], 1) ^ p[2]
rax1.2d v27, v25, v27 ; d[1] = rotl(p[2], 1) ^ p[0]
rax1.2d v25, v28, v25 ; d[4] = rotl(p[0], 1) ^ p[3]
rax1.2d v28, v26, v28 ; d[2] = rotl(p[3], 1) ^ p[1]
rax1.2d v30, v29, v26 // d[0] = rotl(p[1], 1) ^ p[4]
rax1.2d v29, v27, v29 // d[3] = rotl(p[4], 1) ^ p[2]
rax1.2d v27, v25, v27 // d[1] = rotl(p[2], 1) ^ p[0]
rax1.2d v25, v28, v25 // d[4] = rotl(p[0], 1) ^ p[3]
rax1.2d v28, v26, v28 // d[2] = rotl(p[3], 1) ^ p[1]

; Xor parities from step theta into the state at the same time
; as executing rho and pi.
// Xor parities from step theta into the state at the same time
// as executing rho and pi.
eor.16b v0, v0, v30
mov.16b v31, v1
xar.2d v1, v6, v27, 20
Expand Down Expand Up @@ -76,7 +76,7 @@ SOFTWARE.
xar.2d v7, v10, v30, 61
xar.2d v10, v31, v27, 63

; Chi
// Chi
bcax.16b v25, v0, v2, v1
bcax.16b v26, v1, v3, v2
bcax.16b v2, v2, v4, v3
Expand Down Expand Up @@ -117,7 +117,7 @@ SOFTWARE.
mov.16b v20, v25
mov.16b v21, v26

; iota
// iota
ld1r {v25.2d}, [x1], #8
eor.16b v0, v0, v25
.endm
Expand Down