-
Notifications
You must be signed in to change notification settings - Fork 364
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add advisory for unsoundness in intaglio symbol interners (#1732)
See: - artichoke/intaglio#235 - artichoke/intaglio#236 - https://github.com/artichoke/intaglio/releases/tag/v1.9.0
- Loading branch information
Showing
1 changed file
with
27 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
```toml | ||
[advisory] | ||
id = "RUSTSEC-0000-0000" | ||
package = "intaglio" | ||
date = "2023-07-26" | ||
url = "https://github.com/artichoke/intaglio/pull/236" | ||
references = [ | ||
"https://github.com/artichoke/intaglio/issues/235", | ||
"https://github.com/artichoke/intaglio/pull/236", | ||
"https://github.com/artichoke/intaglio/releases/tag/v1.9.0", | ||
] | ||
informational = "unsound" | ||
|
||
[affected] | ||
functions = { "intaglio::SymbolTable::intern" = ["< 1.9.0"], "intaglio::bytes::SymbolTable::intern" = ["< 1.9.0"], "intaglio::cstr::SymbolTable::intern" = ["< 1.9.0, >= 1.5.0"], "intaglio::osstr::SymbolTable::intern" = ["< 1.9.0, >= 1.5.0"], "intaglio::path::SymbolTable::intern" = ["< 1.9.0, >= 1.5.0"] } | ||
|
||
[versions] | ||
patched = [">= 1.9.0"] | ||
``` | ||
|
||
# Unsoundness in `intern` methods on `intaglio` symbol interners | ||
|
||
Affected versions of this crate have a stacked borrows violation when creating | ||
references to interned contents. All interner types are affected. | ||
|
||
The flaw was corrected in version 1.9.0 by reordering move and borrowing | ||
operations and storing interned contents by raw pointer instead of as a `Box`. |