Skip to content

Commit

Permalink
Add advisory for unsoundness in intaglio symbol interners (#1732)
Browse files Browse the repository at this point in the history
  • Loading branch information
lopopolo authored Jul 26, 2023
1 parent 4aa5175 commit 3cf8a93
Showing 1 changed file with 27 additions and 0 deletions.
27 changes: 27 additions & 0 deletions crates/intaglio/RUSTSEC-0000-0000.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "intaglio"
date = "2023-07-26"
url = "https://github.com/artichoke/intaglio/pull/236"
references = [
"https://github.com/artichoke/intaglio/issues/235",
"https://github.com/artichoke/intaglio/pull/236",
"https://github.com/artichoke/intaglio/releases/tag/v1.9.0",
]
informational = "unsound"

[affected]
functions = { "intaglio::SymbolTable::intern" = ["< 1.9.0"], "intaglio::bytes::SymbolTable::intern" = ["< 1.9.0"], "intaglio::cstr::SymbolTable::intern" = ["< 1.9.0, >= 1.5.0"], "intaglio::osstr::SymbolTable::intern" = ["< 1.9.0, >= 1.5.0"], "intaglio::path::SymbolTable::intern" = ["< 1.9.0, >= 1.5.0"] }

[versions]
patched = [">= 1.9.0"]
```

# Unsoundness in `intern` methods on `intaglio` symbol interners

Affected versions of this crate have a stacked borrows violation when creating
references to interned contents. All interner types are affected.

The flaw was corrected in version 1.9.0 by reordering move and borrowing
operations and storing interned contents by raw pointer instead of as a `Box`.

0 comments on commit 3cf8a93

Please sign in to comment.