Skip to content

Add withdrawn field #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 29, 2021
Merged

Add withdrawn field #942

merged 4 commits into from
Jun 29, 2021

Conversation

Shnatsel
Copy link
Member

cargo audit works normally and does not require any changes., but this makes the current linter barf because of unknown field withdrawn.

I have linter with validation for these fields in the osv branch. We could publish that as a pre-release, that would also require a pre-release of rustsec crate.

Another approach is to extract just the linter changes (they seem to be self-contained) and publish a new release. That should work in theory, but I haven't tested that.

Only @tarcieri currently has the permissions to publish rustsec-admin; adding as a reviewer.

@Shnatsel Shnatsel requested a review from tarcieri June 20, 2021 14:08
@tarcieri
Copy link
Member

I can try to take a look at the osv branch soon, or if you'd like to extract the withdrawn-related changes into a separate branch, that works too

@Shnatsel
Copy link
Member Author

I'll get OSV into a mergeable state on Friday. I need to drop some code that's not needed (mostly Git repo parsing) and make OSV export an optional feature. OSV is going to be unstable for now but it's probably worth merging anyway for that pre-release handling fix.

@Shnatsel
Copy link
Member Author

Once OSV branch is ready for review, I'll unmark the PR as draft and @mention you.

This was referenced Jun 23, 2021
@Shnatsel Shnatsel merged commit 84e3fb3 into rustsec:main Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants