-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the timers crate follow submodule design #36
Comments
I don't like having a feature which has the same name as a package dependency (i.e. the |
Wouldn't the full name be |
No, this proposal says that the feature will be called It's unusual to prefix a feature like that, but I'm not against |
Oh sorry, I misread your original comment (assumed you were referring to the crate name). Isn't having a feature named the same as package dependency relatively common? e.g. I see features called |
The future/stream versions are behind the "futures" feature gate. This gate is propagated through the workspace using appropriate feature names. Closes rustwasm#36.
@OddCoincidence I was referring to both the crate name and the feature name (since they're currently the same). Sorry I wasn't clear enough! It may be common, but it's also wrong (or at least heavily problematic): #38 (comment) |
The
crates/timers
crate should follow the submodule design that we came up with in #27 and are formalizing in #34.That is:
callbacks
submodulefutures
modulefutures
crate optionalfutures
submodule when thefutures
feature is enabledThe text was updated successfully, but these errors were encountered: